Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal-cli 0.8.4.1 #79849

Closed

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jun 23, 2021

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` java Java use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle labels Jun 23, 2021
@cho-m cho-m added the build failure CI fails while building the software label Jun 23, 2021
Formula/signal-cli.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Jun 23, 2021
@carlocab carlocab removed the upstream issue An upstream issue report is needed label Jun 23, 2021
@chenrui333 chenrui333 force-pushed the bump-signal-cli-0.8.4.1 branch from b32f816 to 543e90d Compare June 23, 2021 14:54
Formula/signal-cli.rb Outdated Show resolved Hide resolved
@carlocab carlocab added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jun 23, 2021
libsignal-client 0.8.1
@chenrui333 chenrui333 force-pushed the bump-signal-cli-0.8.4.1 branch from 543e90d to b7e7ee0 Compare June 23, 2021 15:04
@chenrui333 chenrui333 removed the build failure CI fails while building the software label Jun 23, 2021
@chenrui333
Copy link
Member Author

@carlocab I dont think it supports 11-arm64?

$ brew unbottled --tag arm64_big_sur signal-cli
==> Populating dependency tree...
==> :arm64_big_sur bottle status
signal-cli: doesn't support this macOS

@carlocab
Copy link
Member

Not sure brew unbottled is right there. But the blocker for ARM is libsignal-client, and upstream says that they now support ARM: signalapp/libsignal#291

But it also looks like the needed changes aren't in the version of libsignal-client that we use.

@carlocab carlocab removed the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jun 23, 2021
@chenrui333
Copy link
Member Author

Not sure brew unbottled is right there.

hmm, interesting.

@chenrui333 chenrui333 added 11-arm64 Big Sur arm64 is specifically affected CI-requeued PR has been re-added to the queue labels Jun 23, 2021
@carlocab carlocab added 10.15 Catalina is specifically affected test failure CI fails while running the test-do block and removed 11-arm64 Big Sur arm64 is specifically affected CI-requeued PR has been re-added to the queue labels Jun 23, 2021
@cho-m
Copy link
Member

cho-m commented Jun 24, 2021

Odd how version test failed only on Catalina.

==> /usr/local/Cellar/signal-cli/0.8.4.1/bin/signal-cli --version
Picked up _JAVA_OPTIONS: -Duser.home=/Users/brew/Library/Caches/Homebrew/java_cache -Djava.io.tmpdir=/private/tmp
Error: signal-cli: failed
An exception occurred within a child process:
  Minitest::Assertion: Expected /tsdevice:\/\?uuid=/ to match "Picked up _JAVA_OPTIONS: -Duser.home=/Users/brew/Library/Caches/Homebrew/java_cache -Djava.io.tmpdir=/private/tmp\n".

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jun 27, 2021
@github-actions github-actions bot closed this Jun 28, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2021
@chenrui333
Copy link
Member Author

#83322

@chenrui333 chenrui333 added superseded PR was replaced by another PR and removed stale No recent activity labels Aug 15, 2021
@chenrui333 chenrui333 deleted the bump-signal-cli-0.8.4.1 branch December 18, 2022 05:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
10.15 Catalina is specifically affected bump-formula-pr PR was created using `brew bump-formula-pr` java Java use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle outdated PR was locked due to age superseded PR was replaced by another PR test failure CI fails while running the test-do block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants