Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afsctool 1.7.2 #95855

Closed
wants to merge 1 commit into from
Closed

afsctool 1.7.2 #95855

wants to merge 1 commit into from

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Feb 25, 2022

fix #95852, #40041

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@rotu rotu changed the title afsctool 1.6.4 1.7.2 afsctool 1.7.2 Feb 25, 2022
@BrewTestBot BrewTestBot added the no Linux bottle Formula has no Linux bottle label Feb 25, 2022
@rotu
Copy link
Contributor Author

rotu commented Mar 1, 2022

@SMillerDev could you take a look at this? I don’t understand the CI failures

Formula/afsctool.rb Outdated Show resolved Hide resolved
@rotu rotu requested a review from danielnachun March 2, 2022 23:37
Formula/afsctool.rb Outdated Show resolved Hide resolved
@rotu rotu requested a review from danielnachun March 3, 2022 06:40
@rotu
Copy link
Contributor Author

rotu commented Mar 3, 2022

I'm backing out Linux support due to build problems. RJVB/afsctool#52

@BrewTestBot BrewTestBot added macos-only Formula depends on macOS and removed no Linux bottle Formula has no Linux bottle labels Mar 3, 2022
@danielnachun
Copy link
Member

I think I know why the Linux build is failing. One problem is that we need to use a newer GCC. We can do this by adding

on_linux do
   depends_on "gcc"
end

fails_with gcc: "5"

The other problem is due to GCC being stricter than clang: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082. I'll post over in the issue you opened with the more detailed possible fix.

Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'll wait for @danielnachun

Thanks for the work @rotu !

@danielnachun
Copy link
Member

Let's get this merged. While the Linux fix seems simple enough, it's probably better to let the upstream developer handle this so for now we can leave this as macOS-only.

@BrewTestBot
Copy link
Member

:shipit: @danielnachun has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2022
@rotu rotu deleted the afsctool branch April 24, 2022 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
macos-only Formula depends on macOS outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Afsctool is outdated (1.6.4 vs 1.7.2)
4 participants