-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
afsctool 1.7.2 #95855
afsctool 1.7.2 #95855
Conversation
@SMillerDev could you take a look at this? I don’t understand the CI failures |
I'm backing out Linux support due to build problems. RJVB/afsctool#52 |
I think I know why the Linux build is failing. One problem is that we need to use a newer GCC. We can do this by adding
The other problem is due to GCC being stricter than clang: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082. I'll post over in the issue you opened with the more detailed possible fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I'll wait for @danielnachun
Thanks for the work @rotu !
Let's get this merged. While the Linux fix seems simple enough, it's probably better to let the upstream developer handle this so for now we can leave this as macOS-only. |
fix #95852, #40041
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?