Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation pipeline #827

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Fix documentation pipeline #827

merged 6 commits into from
Dec 11, 2023

Conversation

ernestum
Copy link
Collaborator

@ernestum ernestum commented Dec 7, 2023

Next attempt at fixing the documentation pipeline.

Right now we had two issues:

  1. we occasionally ran into timeouts when executing the tutorial notebooks.
  2. we are missing dependencies when automatically generating API docs
  3. The readthedocs.yaml file was not hidden.

I fixed 1 by increasing the timeout and splitting up the offending tutorial (GAIL) into more cells so we are less likely to run into the per-cell timeout.

Otherwise the config file was renamed and the dependencies were added.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (629ef9a) 95.64% compared to head (69ab819) 95.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
+ Coverage   95.64%   95.66%   +0.01%     
==========================================
  Files         102      102              
  Lines        9655     9655              
==========================================
+ Hits         9235     9236       +1     
+ Misses        420      419       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernestum
Copy link
Collaborator Author

ernestum commented Dec 8, 2023

@AdamGleave can you merge this one again? Looks like the first try of fixing the documentation pipeline fixed due to other issues which should have been fixed in this PR. Merging this one means another test run for LuaTex

Copy link
Member

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdamGleave AdamGleave merged commit 24a6384 into master Dec 11, 2023
1 of 7 checks passed
@AdamGleave AdamGleave deleted the fix_documentation_pipeline branch December 11, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants