Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

score-k8s #4

Merged
merged 2 commits into from
Sep 11, 2024
Merged

score-k8s #4

merged 2 commits into from
Sep 11, 2024

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Sep 6, 2024

  • score-k8s in .devcontainer
  • score-k8s in Makefile
  • score-k8s in CI

@mathieu-benoit mathieu-benoit changed the title score-k8s score-k8s Sep 6, 2024
@mathieu-benoit mathieu-benoit marked this pull request as draft September 6, 2024 02:06
@mathieu-benoit
Copy link
Contributor Author

Still in progress because store-front and store-admin are not starting properly because of this error:

k logs store-admin-75d855d8bd-vmk8p
/docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
/docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
/docker-entrypoint.sh: Launching /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh
10-listen-on-ipv6-by-default.sh: info: Getting the checksum of /etc/nginx/conf.d/default.conf
10-listen-on-ipv6-by-default.sh: info: /etc/nginx/conf.d/default.conf differs from the packaged version
/docker-entrypoint.sh: Sourcing /docker-entrypoint.d/15-local-resolvers.envsh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/20-envsubst-on-templates.sh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/30-tune-worker-processes.sh
/docker-entrypoint.sh: Configuration complete; ready for start up
2024/09/06 01:53:34 [emerg] 1#1: host not found in upstream "makeline-service" in /etc/nginx/conf.d/default.conf:33
nginx: [emerg] host not found in upstream "makeline-service" in /etc/nginx/conf.d/default.conf:33

That's because of this:
https://github.com/Azure-Samples/aks-store-demo/blob/main/src/store-admin/nginx.conf#L27-L95
Very hard-coded reference to other services...
It's incompatible with how score-k8s names the Service with the -svc suffix:

k get svc
NAME                                 TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)              AGE
kubernetes                           ClusterIP   10.96.0.1       <none>        443/TCP              38m
makeline-service-svc                 ClusterIP   10.96.154.32    <none>        3001/TCP             27m
mongo-makeline-service-948cf5c6      ClusterIP   10.96.80.70     <none>        27017/TCP            27m
order-service-svc                    ClusterIP   10.96.27.123    <none>        3000/TCP             27m
product-service-svc                  ClusterIP   10.96.73.145    <none>        3002/TCP             27m
rabbitmq-makeline-service-61ead8b8   ClusterIP   10.96.16.188    <none>        5672/TCP,15672/TCP   27m
store-admin-svc                      ClusterIP   10.96.184.0     <none>        8081/TCP             27m
store-front-svc                      ClusterIP   10.96.222.186   <none>        8080/TCP             27m

https://github.com/score-spec/score-k8s/blob/main/internal/convert/workloads.go#L283

Looking for options...

@mathieu-benoit
Copy link
Contributor Author

This current issue will be unblocked when a new release of score-k8s will be out including: score-spec/score-k8s#34.

@mathieu-benoit
Copy link
Contributor Author

Now fixed and passing thanks to version: https://github.com/score-spec/score-k8s/releases/tag/0.1.10.

Ready for your review, thanks!

@mathieu-benoit mathieu-benoit marked this pull request as ready for review September 10, 2024 01:19
@mathieu-benoit mathieu-benoit merged commit 25c1ab4 into main Sep 11, 2024
7 checks passed
@mathieu-benoit mathieu-benoit deleted the score-k8s branch September 11, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant