Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow loading #72

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Mia75owo
Copy link
Contributor

This is related to: #70
This is a possible fix for this issue. I don't really like how it is implemented and it isn't really good code
but i wanted to show how my idea of how to fix it.
The loading screen may be not as smooth as the implementation before when running on a very slow device,
but i don't think it's that much of an issue.
Maybe someone can implement this in a better/cleaner way, feel free to send some feedback :)

@drfiemost
Copy link
Member

I don't really like how it is implemented and it isn't really good code but i wanted to show how my idea of how to fix it.

Better mark this as draft then.

On a second tought I'm mostly annoyed by loading times during debug sessions, but then I can use the --novsync flag for a speed-up. For a normal play I think a few seconds wait between levels is tolerable.

@Mia75owo
Copy link
Contributor Author

True, this mostly annoyed me too during debugging, I think I will add a flag to start directly into a level soon :) I will try to clean up this code later. I thought about running the loading bar on a second thread but this would make it way harder to port so I will try to come up with another solution.

@Mia75owo Mia75owo marked this pull request as draft January 1, 2024 10:04
@drfiemost drfiemost linked an issue Sep 3, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DisplayLoadInfo slows down loading.
2 participants