Merge pull request #895 from Hylozoic/fix-saving-group-settings

Fix bug that prevented saving group settings sometimes
Hylozoic · Nov 23, 2022 · c5f8189 · c5f8189
2 parents a94f687 + 2716f13
commit c5f8189
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+### Fixed
+- Bug that prevented saving group settings sometimes
+
 ## [5.0.2] - 2022-11-13
 
 ### Added

diff --git a/api/models/mixins/HasSettings.js b/api/models/mixins/HasSettings.js
@@ -5,7 +5,7 @@ export default {
  this.set('settings', merge({}, this.get('settings'), value))
  if (save) {
  const options = { patch: true }
- if (transacting) settings['transacting'] = transacting
+ if (transacting) options['transacting'] = transacting
  return this.save({settings: this.get('settings')}, options)
  }
  return this