Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openapi discriminator on Datastore types. #2121

Conversation

whitingjr
Copy link
Collaborator

Fixes Issue

#1395

Changes proposed

Add openapi annotations to enhance Datastore type information for clients.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@johnaohara
Copy link
Member

@whitingjr is this ready for review?

@whitingjr whitingjr force-pushed the Horreum-add-discriminator-openapi branch from 595b87a to 079f1e2 Compare October 28, 2024 16:38
@whitingjr whitingjr marked this pull request as ready for review October 31, 2024 09:50
@whitingjr whitingjr requested a review from johnaohara October 31, 2024 09:50
@whitingjr whitingjr force-pushed the Horreum-add-discriminator-openapi branch from 079f1e2 to 3744ee1 Compare October 31, 2024 10:23
@johnaohara
Copy link
Member

The Datastore configuration API will be strongly typed in PR: #2223

PR #2223 will make this obsolete. Thank you for the contribution

@johnaohara johnaohara closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants