lint: Add black and isort #622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Generally all looks good, and looks much tidier from the linting. My only comment relate to two of the commit message prefixes where I think a small change would make them more readily understandable. For 5784d64 I would suggest changing to lint or chore as it's about setting up the linters and not confined to a single file (if you feel strongly about retaining it then I would suggest changing to pyproject.toml). For e914b14 I would suggest changing to ci as I think that's ultimately what it's about and is the prefix that's been used in previous commits. But other than those minor remarks, all looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.