refactor: use YandexWeatherDeviceClass as key for translation

IATkachenko · Aug 17, 2022 · c3e8b6a · c3e8b6a
1 parent b09a386
commit c3e8b6a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 11 deletions.
diff --git a/custom_components/yandex_weather/const.py b/custom_components/yandex_weather/const.py
@@ -1,6 +1,7 @@
 """General constants."""
 from __future__ import annotations
 
+from homeassistant.backports.enum import StrEnum
 from homeassistant.const import Platform
 
 DOMAIN = "yandex_weather"
@@ -185,3 +186,11 @@ def get_image(
     )
 
     return CONDITION_IMAGE[image_source]["link"].format(mapped_image)
+
+
+class YandexWeatherDeviceClass(StrEnum):
+    """State class for weather sensors."""
+
+    WIND_BEARING = f"{DOMAIN}__wind_bearing"
+    CONDITION_YA = f"{DOMAIN}__condition_ya"
+    CONDITION_HA = f"{DOMAIN}__condition_ha"
diff --git a/custom_components/yandex_weather/sensor.py b/custom_components/yandex_weather/sensor.py
@@ -5,7 +5,6 @@
 from datetime import datetime
 import logging
 
-from homeassistant.backports.enum import StrEnum
 from homeassistant.components.sensor import (
     SensorDeviceClass,
     SensorEntity,
@@ -43,18 +42,10 @@
     DOMAIN,
     ENTRY_NAME,
     UPDATER,
+    YandexWeatherDeviceClass,
 )
 from .updater import WeatherUpdater
 
-
-class YandexWeatherDeviceClass(StrEnum):
-    """State class for weather sensors."""
-
-    WIND_BEARING = f"{DOMAIN}__wind_bearing"
-    CONDITION_YA = f"{DOMAIN}__condition_ya"
-    CONDITION_HA = f"{DOMAIN}__condition_ha"
-
-
 WEATHER_SENSORS: tuple[SensorEntityDescription, ...] = (
     SensorEntityDescription(
         key=ATTR_API_TEMPERATURE,

diff --git a/custom_components/yandex_weather/updater.py b/custom_components/yandex_weather/updater.py
@@ -49,6 +49,7 @@
     DOMAIN,
     MANUFACTURER,
     WEATHER_STATES_CONVERSION,
+    YandexWeatherDeviceClass,
     map_state,
 )
 from .device_trigger import TRIGGERS
@@ -80,7 +81,9 @@ def translate_condition(value: str, _language: str) -> str:
     )
     try:
         with open(_translation_location) as f:
-            value = json.loads(f.read())["state"]["yandex_weather__condition_ya"][value]
+            value = json.loads(f.read())["state"][
+                YandexWeatherDeviceClass.CONDITION_YA
+            ][value]
     except FileNotFoundError:
         _LOGGER.debug(f"We have no translation for {_language=} in {_my_location}")
     except KeyError: