Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0.2 Build 107 to Prod #184

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Version 3.0.2 Build 107 to Prod #184

merged 2 commits into from
Sep 5, 2023

Conversation

SMartorelli
Copy link
Member

General Updates

Bug Fixes

Notification Banner/Alert

Enhancements

  • Now the banner/alert UIs use emit sounds only if the Audio System Setting "Play user interface sound effects" is enabled.

Onboarding

Bug Fixes

Pre-launch Checklist

  • I read the Code of Conduct and followed the process outlined there for submitting PRs.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I updated README.md file with new version/info - if applicable.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SMartorelli SMartorelli changed the title Development Version 3.0.2 Build 107 to Prod Sep 5, 2023
@SMartorelli SMartorelli marked this pull request as ready for review September 5, 2023 14:40
Copy link
Member

@jvalentik jvalentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvalentik jvalentik merged commit a5cfd86 into main Sep 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment