ci(cdn): update action #618
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffchew
reviewed
Dec 10, 2024
| AWS_S3_NAME: ${{ secrets.COMMON_COS_BUCKET }} | ||
| run: | | ||
| aws s3 sync ${{ env.SOURCE_DIR }} s3://${{ env.AWS_S3_NAME }}${{ env.DEST_DIR_A }} && aws s3 sync ${{ env.SOURCE_DIR }} s3://${{ env.AWS_S3_NAME }}${{ env.DEST_DIR_B }} |
There was a problem hiding this comment.
As mentioned, be sure you are setting -- recursive and --endpoint-url when using the aws cli, as we are not hosting on AWS. I pinged you in Slack with the details.
There was a problem hiding this comment.
COMMON_COS_ENDPOINT is the secret you can use to set the endpoint in the command.
Also, it would be safer to use cp over sync.
There was a problem hiding this comment.
@jeffchew please review the latest. I have changed the setup to use directly aws cli. Also I did included the arguments from the original action --acl public-read --follow-symlinks as they were missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.