Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor Neo4jClient to avoid using a global UnirestInstance #108

Merged
merged 1 commit into from
Nov 13, 2023
Merged

chore: refactor Neo4jClient to avoid using a global UnirestInstance #108

merged 1 commit into from
Nov 13, 2023

Conversation

ClemDoum
Copy link
Collaborator

@ClemDoum ClemDoum commented Oct 25, 2023 •
edited
Loading

PR description

PR description

Previously the Neo4jClient was using Unirest.xxxxxxx instead of wrapping a UnirestInstance instance.
This approaches caused test to be sometimes flaky when anything was happening to that single UnirestInstance instance (connection pool stop, disconnected or anything).

Changes

src

Changed

  • refactor Neo4jClient to wrap a UnirestInstance instance and avoid using a global UnirestInstance

@ClemDoum ClemDoum changed the title Feature/refactor neo4j client feature: refactor Neo4jClient to avoid using a global UnirestInstance Oct 25, 2023
@ClemDoum ClemDoum self-assigned this Oct 25, 2023
@ClemDoum ClemDoum added the java label Oct 25, 2023
@ClemDoum ClemDoum changed the base branch from main to feature/graph-import October 25, 2023 14:18
@ClemDoum ClemDoum marked this pull request as ready for review October 25, 2023 14:18
@ClemDoum ClemDoum requested a review from a team as a code owner October 25, 2023 14:18
@ClemDoum ClemDoum mentioned this pull request Oct 25, 2023
Merged
1 task
@ClemDoum ClemDoum changed the title feature: refactor Neo4jClient to avoid using a global UnirestInstance chore: refactor Neo4jClient to avoid using a global UnirestInstance Oct 25, 2023
@ClemDoum ClemDoum force-pushed the feature/graph-import branch from d581f60 to 9245e77 Compare October 30, 2023 16:38
@ClemDoum ClemDoum force-pushed the feature/refactor-neo4j-client branch from 9010f2b to feef7be Compare October 30, 2023 16:40
@ClemDoum ClemDoum force-pushed the feature/graph-import branch from 9245e77 to e4d9c56 Compare October 31, 2023 17:31
@ClemDoum ClemDoum force-pushed the feature/refactor-neo4j-client branch from feef7be to 8fcc393 Compare October 31, 2023 17:32
Base automatically changed from feature/graph-import to main November 13, 2023 09:08
@ClemDoum ClemDoum force-pushed the feature/refactor-neo4j-client branch from 8fcc393 to 24b4745 Compare November 13, 2023 09:11
@ClemDoum ClemDoum merged commit abb5ecc into main Nov 13, 2023
2 checks passed
@ClemDoum ClemDoum deleted the feature/refactor-neo4j-client branch November 13, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirhoo pirhoo pirhoo approved these changes

Assignees

@ClemDoum ClemDoum

Labels
java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClemDoum @pirhoo