Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing effort controller dependency. #13

Closed

Conversation

JacobJBeck
Copy link

Ran into issues due to missing ros-humble-effort-controllers, so I've added that package as a dependency.

@tpoignonec
Copy link
Member

Hi!

Actually, fd_hardware defines a ros2control hardware interface, so it is independent from the actual controller used.

An explicit dependency in fd_description would make sense, although looking at the package now, it seems we put everything in fd_bringup so far... (e.g., joint_state_publisher).

Besides, it should be an "exec_depend", not a "depend", because the controller is just a plugin loaded at runtime.

@JacobJBeck ros-humble-effort-controllers was the only missing dependency on a clean distro ?

@tpoignonec
Copy link
Member

This dep was added to the list (#16 ).

@tpoignonec tpoignonec closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants