Skip to content

Commit

Permalink
Address minor issues identified in 10/24 Code Audit (#1504)
Browse files Browse the repository at this point in the history
* Update code owners

* Trying xfail PHE tests only on Windows

* Revert change on xfailed tests for PHE

* Update .github/CODEOWNERS

* Update idaes/models_extra/column_models/tests/test_plate_heat_exchanger.py
  • Loading branch information
Andrew Lee authored Oct 28, 2024
1 parent d931060 commit 1ed3f2c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
7 changes: 4 additions & 3 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,14 @@ conftest.py @lbianchi-lbl
/idaes/commands/ @dangunter

# Core
/idaes/core/ @andrewlee94 @dallan-keylogic @lbianchi-lbl
/idaes/core/ @agarciadiego @dallan-keylogic @lbianchi-lbl
/idaes/core/dmf/ @dangunter
/idaes/core/surrogate/ @andrewlee94 @bpaul4 @avdudchenko @rundxdi
/idaes/core/surrogate/ @bpaul4 @avdudchenko @rundxdi
/idaes/core/ui/ @dangunter

# Models
/idaes/models/ @andrewlee94 @bpaul4
/idaes/models/ @agarciadiego @bpaul4
/idaes/models/properties/ @agarciadiego @dallan-keylogic

# Apps - each package needs a maintainer
/idaes/apps/caprese/ @Robbybp
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,17 @@
Tests for Plate Heat Exchnager unit model.
Author: Akula Paul
"""

import pytest

from pyomo.environ import (
check_optimal_termination,
ConcreteModel,
Param,
units as pyunits,
value,
)
from pyomo.util.check_units import assert_units_consistent, assert_units_equivalent

from idaes.core import FlowsheetBlock
from idaes.models_extra.column_models.plate_heat_exchanger import (
PlateHeatExchanger as PHE,
Expand All @@ -37,7 +39,6 @@
from idaes.core.util.model_statistics import degrees_of_freedom
from idaes.core.util.testing import initialization_tester
from idaes.core.solvers import get_solver
from pyomo.util.check_units import assert_units_consistent, assert_units_equivalent


# -----------------------------------------------------------------------------
Expand Down Expand Up @@ -66,8 +67,9 @@ def test_config():


workaround_for_1294 = pytest.mark.xfail(
# the failures only occur for Windows on GHA with Python <3.12, and Linux with Python 3.12
reason="These tests fail with Pyomo 6.7.0. See IDAES/idaes-pse#1294 for details",
strict=False, # the failures only occur for certain platforms, e.g. Windows on GHA
strict=False,
)


Expand Down

0 comments on commit 1ed3f2c

Please sign in to comment.