Removing unnecessary test for legacy solver wrapper

idaes/core/solvers/get_solver.py

@@ -14,7 +14,6 @@
 """
 This module contains the IDAES get_solver method.
 """
-from pyomo.contrib.solver.base import LegacySolverWrapper
 
 import idaes.logger as idaeslog
 import idaes.core.solvers
@@ -58,23 +57,11 @@ def get_solver(
         solver = "default"
     solver_obj = idaes.core.solvers.SolverWrapper(solver, register=False)()
 
-    if isinstance(solver_obj, LegacySolverWrapper):
-        # New solver interface.
-        # LegacySolverWrapper is a wrapper for the new solver interface that makes it
-        # backward compatible.
-        if options is not None:
-            for k, v in options.items():
-                solver_obj.options[k] = v
-        if writer_config is not None:
-            for k, v in writer_config.items():
-                solver_obj.config.writer_config[k] = v
-    else:
-        # Old solver interface
-        if options is not None:
-            solver_obj.options.update(options)
-        if writer_config is not None:
-            _log.info(
-                "Older Pyomo solver interface does not support writer_config argument: ignoring."
-            )
+    if options is not None:
+        for k, v in options.items():
+            solver_obj.options[k] = v
+    if writer_config is not None:
+        for k, v in writer_config.items():
+            solver_obj.config.writer_config[k] = v
 
     return solver_obj

idaes/core/solvers/tests/test_solvers.py

@@ -278,24 +278,12 @@ def test_get_solver_default():
 
 @pytest.mark.skipif(not pyo.SolverFactory("ipopt").available(False), reason="no Ipopt")
 @pytest.mark.unit
-def test_get_solver_default_solver_w_options(caplog):
-    solver = get_solver(
-        options={"foo": "bar", "tol": 1e-5}, writer_config={"foo": "bar"}
-    )
-
-    assert not isinstance(solver, LegacySolverWrapper)
-
-    assert solver.options == {
-        "nlp_scaling_method": "gradient-based",
-        "tol": 1e-5,
-        "max_iter": 200,
-        "foo": "bar",
-    }
-
-    assert (
-        "Older Pyomo solver interface does not support writer_config argument: ignoring."
-        in caplog.text
-    )
+def test_get_solver_default_solver_w_options():
+    with pytest.raises(
+        AttributeError,
+        match="'IPOPT' object has no attribute 'config'",
+    ):
+        get_solver(options={"foo": "bar", "tol": 1e-5}, writer_config={"foo": "bar"})
 
 
 @pytest.mark.skipif(not pyo.SolverFactory("ipopt").available(False), reason="no Ipopt")