Skip to content

Commit

Permalink
Push latest main to branch (#1394)
Browse files Browse the repository at this point in the history
* Resolve CI failures from new version (1.20.4) of spellchecker (#1389)

* Empty commit to verify failures on main

* Resolve likely false positives

* Resolve likely true positives

* Resolve probable true positive

* Remove "frst" from typos exclusions

* Remove "ans" from typos exclusions b/c crate-ci/typos#981

* Fix target for 'fv' (flowsheet visualizer) reference (#1391)

* outputs

* fix hyperlink

* put this back

* put this back2

* replace with simple hyperlink

* Updating black and rerunning it on all files (#1388)

* Updating black and rerunning it on all files

* Remove duplicated Black requirement

* Update Black rev in pre-commit config

---------

Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov>

---------

Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov>
Co-authored-by: Dan Gunter <dkgunter@lbl.gov>
Co-authored-by: Keith Beattie <ksbeattie@lbl.gov>
  • Loading branch information
4 people authored Apr 10, 2024
1 parent 8948c6c commit 88553c1
Show file tree
Hide file tree
Showing 71 changed files with 291 additions and 579 deletions.
1 change: 1 addition & 0 deletions .github/actions/run-examples/examples_for_idaes_ci.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""
pytest plugin for testing IDAES "through" IDAES/examples within the IDAES/idaes-pse CI
"""

from contextlib import contextmanager
from dataclasses import dataclass, field
import fnmatch
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/typos.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,10 @@ astroid = "astroid"
delt = "delt"
# TEMPORARY - Remove after example update
upadate = "upadate"

# false positive from 1.20.3
RTO = "RTO"
PN = "PN"
hd = "hd"
Tge = "Tge"
iy = "iy"
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/psf/black
rev: 22.3.0
rev: 24.3.0
hooks:
- id: black
language_version: python3
Expand Down
1 change: 1 addition & 0 deletions .pylint/idaes_transform.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
See #1159 for more information.
"""

from dataclasses import dataclass
import sys
import functools
Expand Down
2 changes: 1 addition & 1 deletion docs/explanations/components/ui/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ User Interfaces
There are several types of user interfaces in IDAES.
To learn more about them, follow the links below.

* Graphical user interfaces: see `Flowsheet Visualizer <https://idaes-ui.readthedocs.io/en/latest/fv.html>`_
* Graphical user interfaces: see `Flowsheet Visualizer <https://idaes-ui.readthedocs.io/en/latest/user/fv/>`_
* `Jupyter Notebooks <https://jupyter.org/>`_: see `IDAES Examples <https://idaes-examples.readthedocs.io/en/latest/>`_
* Python Application Programming Interfaces (APIs): see :ref:`API Reference`

Expand Down
2 changes: 1 addition & 1 deletion docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ Contents
| :doc:`Logging Processing & Outputs <reference_guides/logging>`
| :doc:`Developing for IDAES <reference_guides/developer/index>`
| :doc:`Grid integration application <reference_guides/apps/grid_integration/index>`
| :external+ui:doc:`Flowsheet Visualizer <fv>`
| `Flowsheet Visualizer <https://idaes-ui.readthedocs.io/en/latest/user/fv/>`_
.. toctree::
:hidden:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ Heat Exchanger Cost

.. note:: IDAES does not yet support costing for heat exchangers requiring both shell and tube area (HX1D).

The purchse cost is computed based on the base unit cost and three correction factors (Eq. 22.43 in Seider et al.), and is adjusted by user-defined currency units with the appropriate CE index value. The base cost is computed depending on the heat exchanger type selected by the user.
The purchase cost is computed based on the base unit cost and three correction factors (Eq. 22.43 in Seider et al.), and is adjusted by user-defined currency units with the appropriate CE index value. The base cost is computed depending on the heat exchanger type selected by the user.

The heat exchanger costing method has three arguments, hx_type = heat exchanger type, material_type = construction material, and tube_length = tube length ('*' corresponds to the default options):

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Option 1 - "FTPz":
<ul>
<li>Total molar flow rate (mol/s) - <code> <font color="red"> flow_mol </font> </code>
<li>Temperature (K) - <code> <font color="red"> temperature </font> </code>
<li>Presure (Pa) - <code> <font color="red"> pressure</font></code>
<li>Pressure (Pa) - <code> <font color="red"> pressure</font></code>
<li>Mole fraction of the mixture - <code> <font color="red"> mole_frac_comp</font></code>
</ul>
</body>
Expand All @@ -43,7 +43,7 @@ Option 2 - "FcTP":
<ul>
<li>Component molar flow rate (mol/s) - <code> <font color="red"> flow_mol_comp </font> </code>
<li>Temperature (K) - <code> <font color="red"> temperature </font> </code>
<li>Presure (Pa) - <code> <font color="red"> pressure</font></code>
<li>Pressure (Pa) - <code> <font color="red"> pressure</font></code>
</ul>
</body>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ List of Variables
"``fug_phase_comp``", "Fugacity indexed by phase and component", "Pa"
"``fug_coeff_phase_comp``", "Fugacity coefficient indexed by phase and component", "None"
"``gibbs_mol_phase``", "Molar Gibbs energy indexed by phase", "J/mol"
"``heat_capacity_ratio_phase``", "Heat capcity ratio by phase", "-"
"``heat_capacity_ratio_phase``", "Heat capacity ratio by phase", "-"
"``isothermal_speed_sound_phase``", "Isothermal speed of sound by phase", "m/s"
"``isentropic_speed_sound_phase``", "Isentropic speed of sound by phase", "m/s"
"``mw``", "Molecular weight of mixture", "kg/mol"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ The function has has five arguments, self, equipment, scaled_param, temp_C, and
* self : an existing unit model or Pyomo Block
* equipment : The type of equipment to be costed, see table 6
* scaled_param : The Pyomo Variable representing the component's scaled parameter
* temp_C : The Pyomo Variable representing the hottest temperature of the piece of equiment being costed. Some pieces of equipment do not have a temperature associated with them, so the default argument is None. This variable must have units of Celsius (Pyomo label `pyunits.C`).
* temp_C : The Pyomo Variable representing the hottest temperature of the piece of equipment being costed. Some pieces of equipment do not have a temperature associated with them, so the default argument is None. This variable must have units of Celsius (Pyomo label `pyunits.C`).
* n_equip : The number of pieces of equipment to be costed. The function will evenly divide the scaled parameter between the number passed.
* CE_index_year : Chemical Engineering Cost Index base year, defaults to 2018; calling the registered Pyomo currency units dictionary of plant cost index values will allow conversion between base years within the flowsheet
* custom_accounts : Additional accounts to cost
Expand Down
Loading

0 comments on commit 88553c1

Please sign in to comment.