Update Pylint to 3.0.3 #1351
Merged
Update Pylint to 3.0.3 #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbianchi-lbl
requested review from
MAZamarripa,
AlexNoring,
eslickj,
aostace01,
agarciadiego,
andrewlee94,
carldlaird,
bpaul4,
dangunter and
ksbeattie
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1351 +/- ##
==========================================
- Coverage 77.58% 77.58% -0.01%
==========================================
Files 391 391
Lines 64288 64288
Branches 11815 11812 -3
==========================================
- Hits 49881 49879 -2
- Misses 11825 11828 +3
+ Partials 2582 2581 -1 ☔ View full report in Codecov by Sentry. |
andrewlee94
approved these changes
Feb 23, 2024
| @@ -356,6 +368,8 @@ def __init__( | |||
| print("The default training/cross-validation split of 0.75 is used.") | |||
| training_split = 0.75 | |||
| elif training_split >= 1 or training_split <= 0: | |||
| # PYLINT-TODO | |||
| # pylint: disable-next=broad-exception-raised | |||
There was a problem hiding this comment.
Not for this PR, but this looks like we should create an issue about using more specific error types here.
There was a problem hiding this comment.
I definitely agree, I almost thought I could do it as part of this PR since it's straightforward from the technical point of view, but then I thought we might want to think it through a bit more. I've just created #1352 to track this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
This was originally part of #1346, but I thought it would be better to move the Pylint-specific changes to a separate PR.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: