Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code clean up for Feb24 release #1357

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

andrewlee94
Copy link
Member

Fixes None

Summary/Motivation:

This PR addresses some minor code clean up identified in the February 2024 code audit.

Changes proposed in this PR:

  • Remove legacy docs_archive folder and contents
  • Update code owners to replace team members who are no longer part of the project

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@andrewlee94 andrewlee94 self-assigned this Feb 28, 2024
@andrewlee94 andrewlee94 added the Priority:Normal Normal Priority Issue or PR label Feb 28, 2024
@andrewlee94 andrewlee94 requested a review from bpaul4 February 28, 2024 21:27
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie enabled auto-merge (squash) February 29, 2024 20:04
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.60%. Comparing base (4dd3c2d) to head (41cbb85).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1357      +/-   ##
==========================================
- Coverage   77.60%   77.60%   -0.01%     
==========================================
  Files         391      391              
  Lines       64315    64315              
  Branches    14235    14235              
==========================================
- Hits        49913    49910       -3     
- Misses      11829    11833       +4     
+ Partials     2573     2572       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksbeattie ksbeattie merged commit 28e9ae6 into IDAES:main Feb 29, 2024
45 checks passed
@andrewlee94 andrewlee94 deleted the 0224_code_audit branch June 21, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants