Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parameter sweep tool to support indexed vars #1387

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

andrewlee94
Copy link
Member

Fixes None

Summary/Motivation:

This PR allows users of the parameter sweep tool to specify a value for an IndexedVar as a whole, rather than individual elements. All elements will be set to the same value.

Changes proposed in this PR:

  • Support for indexed variables in parameter sweep tool
  • Clean up a few unused imports in other test files

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@andrewlee94 andrewlee94 self-assigned this Mar 28, 2024
@andrewlee94 andrewlee94 added enhancement New feature or request Priority:Normal Normal Priority Issue or PR core Issues dealing with core modeling components labels Mar 28, 2024
@lbianchi-lbl lbianchi-lbl changed the title Updte parameter sweep tool to support indexed vars Update parameter sweep tool to support indexed vars Mar 28, 2024
Copy link
Contributor

@bpaul4 bpaul4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks nice! Is there a reason some imports were removed in the heat exchanger test files?

@andrewlee94
Copy link
Member Author

@bpaul4 They were left over imports from before I added the DiagnsoticsToolbox tests that were not cleaned up (and pylint is set to ignore test files so it didn't raise any warnings).

Copy link
Contributor

@agarciadiego agarciadiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlee94 andrewlee94 enabled auto-merge (squash) April 11, 2024 18:38
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.62%. Comparing base (40d3dc7) to head (59888d3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1387      +/-   ##
==========================================
- Coverage   77.63%   77.62%   -0.01%     
==========================================
  Files         391      391              
  Lines       64386    64392       +6     
  Branches    14262    14264       +2     
==========================================
+ Hits        49984    49987       +3     
- Misses      11830    11834       +4     
+ Partials     2572     2571       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewlee94 andrewlee94 merged commit 45c8ff0 into IDAES:main Apr 11, 2024
49 checks passed
@andrewlee94 andrewlee94 deleted the parameter_sweep_tweeks branch April 11, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues dealing with core modeling components enhancement New feature or request Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants