-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parameter sweep tool to support indexed vars #1387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks nice! Is there a reason some imports were removed in the heat exchanger test files?
@bpaul4 They were left over imports from before I added the DiagnsoticsToolbox tests that were not cleaned up (and pylint is set to ignore test files so it didn't raise any warnings). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1387 +/- ##
==========================================
- Coverage 77.63% 77.62% -0.01%
==========================================
Files 391 391
Lines 64386 64392 +6
Branches 14262 14264 +2
==========================================
+ Hits 49984 49987 +3
- Misses 11830 11834 +4
+ Partials 2572 2571 -1 ☔ View full report in Codecov by Sentry. |
Fixes None
Summary/Motivation:
This PR allows users of the parameter sweep tool to specify a value for an IndexedVar as a whole, rather than individual elements. All elements will be set to the same value.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: