Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for issue #1364: catch AttributeError in set_scaling_from_default #1400

Merged
merged 2 commits into from
Apr 25, 2024
Merged

bug fix for issue #1364: catch AttributeError in set_scaling_from_default #1400

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f92d34e
bug fix: catch AttributeError in set_scaling_from_default
jasonmbray-p66 Mar 5, 2024
fb605bb
Merge branch 'main' into issue-1364
lbianchi-lbl Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions idaes/core/util/scaling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,9 +1179,15 @@ def set_scaling_from_default(
return

parent = component.parent_block()
dsf = parent.get_default_scaling(
component.parent_component().local_name, index=component.index()
)
try:
dsf = parent.get_default_scaling(
component.parent_component().local_name, index=component.index()
)
except AttributeError:
dsf = None
_log.warning(
f"{component.name} block missing 'get_default_scaling()' method, no scaling factor assigned."
)

if dsf is not None:
set_scaling_factor(component, dsf, overwrite=overwrite)
Expand Down
Loading