-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming components #1402
Renaming components #1402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, pending the tests passing once the branch is updated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1402 +/- ##
==========================================
- Coverage 77.89% 77.88% -0.01%
==========================================
Files 394 394
Lines 65061 65053 -8
Branches 14383 14383
==========================================
- Hits 50678 50667 -11
- Misses 11793 11797 +4
+ Partials 2590 2589 -1 ☔ View full report in Codecov by Sentry. |
Related to Pyomo/pyomo#3221
Requires a fix in Pyomo and/or OMLT to address exception due to sub-classing metaclass. Will also require the Pyomo dependency to be updated.
Summary/Motivation:
This PR updates IDAES to use the new public names for Pyomo component data classes.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: