Infeasibility diagnostic tool #1409
Conversation
|
The spell checker is hitting false positives on "mis" and "MIS". |
idaes/core/util/model_diagnostics.py
Outdated
| ConfigValue( | ||
| default=1e-6, | ||
| domain=float, | ||
| description="Feasiblity tolerance for idenifying infeasible constraint and bounds", |
There was a problem hiding this comment.
Also "feasiblty" I believe
There was a problem hiding this comment.
It should probably also be constraints (plural).
idaes/core/util/model_diagnostics.py
Outdated
| @@ -3887,6 +3930,51 @@ def b_rule(b, i): | |||
| return ill_cond | |||
|
|
|||
|
|
|||
| def compute_infeasibility_explanation( | |||
There was a problem hiding this comment.
Does this need to be done as a separate method, or could it just be written directly into the toolbox class?
There was a problem hiding this comment.
I agree -- I couldn't decide at what level things should be integrated. Implemented this suggestion in 40670e4.
idaes/core/util/model_diagnostics.py
Outdated
| @@ -3887,6 +3930,51 @@ def b_rule(b, i): | |||
| return ill_cond | |||
|
|
|||
|
|
|||
| def compute_infeasibility_explanation( | |||
| model, solver, tee=False, tolerance=1e-6, stream=None | |||
There was a problem hiding this comment.
I think we should have solver=None here, and a check for:
if solver is None:
solver = get_solver()
idaes/core/util/model_diagnostics.py
Outdated
| that removing any single constraint or variable bound would result in a | ||
| feasible subsystem. | ||
|
|
||
| This function is a wrapper for the same capability in pyomo.contrib.iis.mis. |
There was a problem hiding this comment.
You will need to add a few exclusions to the spell-checker file as well.
|
@bknueven You can add exclusions for the spell checker here: https://github.com/IDAES/idaes-pse/blob/main/.github/workflows/typos.toml |
andrewlee94
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
==========================================
- Coverage 77.89% 77.88% -0.01%
==========================================
Files 394 394
Lines 65053 65069 +16
Branches 14383 14385 +2
==========================================
+ Hits 50670 50680 +10
- Misses 11793 11798 +5
- Partials 2590 2591 +1 ☔ View full report in Codecov by Sentry. |
Fixes #1405
Summary/Motivation:
See discussion on #1405
Changes proposed in this PR:
pyomo.contrib.iis.mis.compute_infeasibility_explanationtoidaes.core.util.model_diagnositics(6099416)compute_infeasibility_explanationinto theDiagnosticsToolbox(a931a77)Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: