-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimal pytest plugin to verify that generated files are cleaned up by tests #1488
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1488 +/- ##
==========================================
- Coverage 76.84% 76.83% -0.02%
==========================================
Files 376 376
Lines 61091 61170 +79
Branches 13505 13518 +13
==========================================
+ Hits 46948 46999 +51
- Misses 11762 11788 +26
- Partials 2381 2383 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…up by tests (#1488) * Add pytest plugin to verify that test modules clean up any generated file * Format with Black and remove unused import * Add docstring to make Pylint happy * Format with Black * Switch to per-test file checks and Python 3.9+ type hinting * Apply fixtures to offending tests * Try resolving next batch of failures * Try addressing two failures * Switch to using module-level fixture for tmp_path workdir (cherry picked from commit 9ee1fad)
Summary/Motivation:
idaes.core.dmf.util
through manipulation of temporary directories and/or the working directoryLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: