Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding StreamScaler unit model, along with the test and rst file. #1517
Adding StreamScaler unit model, along with the test and rst file. #1517
Changes from 10 commits
43982e5
00576ac
1adb5b2
0af89d1
f689ae1
288a39e
9c512e8
0d4d244
ff9a777
603c4b5
086e80f
91a0f64
4bc4aea
40ac61a
11da999
85b1679
30565ec
7fa9c2a
15a0426
194f476
a96f827
2df7345
c957d4a
faced0b
779296e
89e326b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct from reading the code. The inlet state has a different name, and there is a separate (empty) outlet Block.
Check warning on line 17 in idaes/models/unit_models/stream_scaler.py
GitHub Actions / Pylint
W0611 (unused-import)
Check warning on line 29 in idaes/models/unit_models/stream_scaler.py
GitHub Actions / Pylint
W0611 (unused-import)
Check warning on line 29 in idaes/models/unit_models/stream_scaler.py
GitHub Actions / Pylint
W0611 (unused-import)
Check warning on line 29 in idaes/models/unit_models/stream_scaler.py
GitHub Actions / Pylint
W0611 (unused-import)
Check warning on line 29 in idaes/models/unit_models/stream_scaler.py
GitHub Actions / Pylint
W0611 (unused-import)
Check warning on line 31 in idaes/models/unit_models/stream_scaler.py
GitHub Actions / Pylint
W0611 (unused-import)
Check warning on line 31 in idaes/models/unit_models/stream_scaler.py
GitHub Actions / Pylint
W0611 (unused-import)
Check warning on line 39 in idaes/models/unit_models/stream_scaler.py
GitHub Actions / Pylint
W0611 (unused-import)
Check warning on line 202 in idaes/models/unit_models/stream_scaler.py
GitHub Actions / Pylint
W0612 (unused-variable)
Check warning on line 203 in idaes/models/unit_models/stream_scaler.py
GitHub Actions / Pylint
W0612 (unused-variable)