Search engine studies #20

will-moore · 2022-10-03T15:38:40Z

Looking to use omero_search_engine backend for searching for studies.

Currently, changes in this PR only affect the search page (not front page).

Auto-complete for "Any" includes Key-Value pairs for Projects and Screens:

…bute menu

jburel · 2022-11-29T13:40:50Z

@will-moore code formatting check is red

jburel · 2022-11-29T13:45:35Z

The behaviour on idr-testing is very strange.
I am looking for photon in the "search Result page"

will-moore · 2022-11-29T16:35:12Z

You can't search with key "Any". You need to pick one of the auto-complete options

jburel · 2022-12-06T11:49:26Z

@will-moore could you review the formatting? It has been failing with the past few commits

will-moore · 2022-12-08T16:02:37Z

TODOs from today's meeting @francesw @jburel @khaledk2 @pwalczysko

Always use "contains" operator when redirecting from old "query=..." search pages
Use "contains" operator by default
When using auto-complete with a specific Attribute (not "Any"), add an "all / contains X" option that will use the currently-entered search term with "contains" query. Choosing other exact autocomplete matches will use "equals".
On front page, fix search by Name, don't show "annotations.csv" matches.

jburel · 2023-01-25T10:23:01Z

Term "experiments+screens" should be used when displaying results
Term "undefined" is displayed in from of the screen entries

jburel · 2023-01-25T13:32:51Z

idr_gallery/static/idr_gallery/omero_search_form.js

@@ -743,7 +750,7 @@ class OmeroSearchForm {
    let thead = `<li class="studyRow resultsHeader">
      <div class="studyColumns">
        <div class="caret"></i></div>
-        <div class="studyId">Study ID</div>
+        <div title="Experiment or Screen ID" class="studyId">ID</div>


i thought we were going for just ID. Let see how it is displayed

will-moore · 2023-01-25T14:00:47Z

Re-deployed those fixes to idr-testing..

will-moore · 2023-01-27T09:53:03Z

Before that last commit, we had "experiments" in the first line of auto-complete (when a key is chosen). Now it is experiments/screens:

Also, the results table mentioned "Studies" and "Study ID", but these are now replaced with "Experiments/Projects"

francesw · 2023-01-27T14:24:37Z

When searching with "Any, contains, microscopy", the top hit from the pop up is imaging method (50 screens), but when you click on this, the results show 86 experiments/screens.

…bining them

will-moore · 2023-01-30T12:45:02Z

Auto-complete with "Any" key and "contains" now has greater-than/equals sign:

redeployed now

jburel · 2023-01-30T13:47:10Z

The symbol > is displayed
But this is not right. The total indicates XXX number of screens/experimenters (Huge number)
but the count is for images. This area really needs to be reviewed, I am leaning towards removing the count from the display for this release and sort it. Even if it is a solely a software release in a week or so

jburel · 2023-01-30T14:35:04Z

Should be ``experiment/screen``

will-moore · 2023-01-30T20:25:14Z

This is my current auto-complete testing matrix:

With "Any" key and "contains":

All auto-complete items use "contains" and "> count". The object types should be correct: "experiments" or "screens" or "experiments/screens" or "images".

With "Any" key and "equals":

Choosing any of these items - the number in the auto-complete should match the search result

With a chosen Key: (Study attribute or Image attribute)

The operator makes no difference to auto-complete. First item returned should be "contains" the current value with correct sum:

will-moore · 2023-01-31T12:31:54Z

Those last 2 commits address 2 issues discussed this morning (not related to this PR but easier to fix here to avoid conflicts etc):

In Safari, the default form submission handling causes the page to be refreshed when you hit enter
In all browsers, when some auto-complete results are showing, if you edit the value in the field (either by typing or deleting or both) and then hit Enter before the auto-complete has fetched new results, the previous value will still be highlighted and will be selected to perform a search. Now, we hide the previous autocomplete results as soon as the user types in the field.

pwalczysko · 2023-01-31T13:43:18Z

The behaviour is as expected for the two issues fixed in last commit.

I have one more bug:

Have on the search page selected Gene symbol and then typed into Keys Carpenter. I get No results found which is exapected. Then, I click 2 times up arrow and down arrow on my keyboard. The content of the "Value" box is changed to "-1" (note that I did not type in "-1").

pwalczysko · 2023-02-01T09:46:28Z

As discussed, I will create a separate issue from #20 (comment)

Ready to merge fmpov

will-moore · 2023-02-01T09:51:11Z

As discussed just now: @jburel, @francesw Good to merge...

pwalczysko · 2023-02-01T11:37:10Z

created issue #24

will-moore added 4 commits September 28, 2022 10:51

Initial support for screen/project attributes search form

5108b82

Fix handling of 'resource' for project, screen etc

28d0417

Merge remote-tracking branch 'origin/master' into search_engine_studies

4276e88

prettier fixes

08d0a6f

will-moore mentioned this pull request Nov 17, 2022

searchvalues not returning study Names ome/omero_search_engine#54

Open

Auto-complete 'Any' searches container Name and Description

602a643

will-moore mentioned this pull request Nov 26, 2022

Search for studies by KV pairs, Name & Description #22

Closed

will-moore added 6 commits November 28, 2022 12:15

Fix auto-complete for Name/Description

439a9f4

Search for 'container' instead of project/screen. Show Study in Attri…

301eaaf

…bute menu

prettier fixes

ad73bf9

Don't alert() if no results. Display instead

d31db87

Don't include Description for auto-complete terms

cea6325

Ignore annotation.csv KV pairs from auto-complete results

c574b70

will-moore added 2 commits December 5, 2022 14:45

Use 'name' instead of 'Name (IDR number)' for search_engine API

edab857

Don't show 'name' in Attribute chooser

8b24932

will-moore added 7 commits December 7, 2022 12:13

Move autocomplete functionality to reusable function

8ea2b7c

Fix sorting of autocomplete results by image, screen OR project counts

87e417d

Use 'experiment' instead of 'project' in autocomplete

d8ee001

Use result.count for autocomplete display

fc3b853

Generate auto-complete results grouped by key - console.log only

8ce5b62

Handle redirect for non-mapr queries on studies

9743a5d

Use resource:container for loading study images

52ed6ab

will-moore force-pushed the search_engine_studies branch from ce61b1f to 52ed6ab Compare December 7, 2022 14:50

will-moore added 2 commits December 8, 2022 16:30

Use 'contains' for Image-attribute redirects

5e68658

Switch operator order in UI, contains first default

9119e95

will-moore added 3 commits January 25, 2023 13:21

Replace 'study' with 'experiment/screen' in autocomplete and results

4b6b3d2

Fix 'undefined' operator in autocomplete

2809efb

prettier

479a430

jburel reviewed Jan 25, 2023

View reviewed changes

will-moore added 5 commits January 27, 2023 14:51

Combine project and screen hits in autocomplete

6e210ac

Fix autocomplete contains experiments/screens, update 'type' when com…

62b359f

…bining them

Don't search with 'Any' for key

774021a

Autocomplete results count greater-than if 'contains'

705bbe7

prettier fixes

ef6c120

Fix type in autocomplete for first line 'contains'

1c7601b

Fix the combining of multiple auto-complete types for 'Any' first item

595fc1f

will-moore added 2 commits January 31, 2023 11:27

Hide stale auto-complete results on keyup (except arrows)

596d916

Disable default form submission handling

5c31a23

will-moore force-pushed the search_engine_studies branch from 631d8ae to 5c31a23 Compare January 31, 2023 11:50

pwalczysko approved these changes Feb 1, 2023

View reviewed changes

will-moore merged commit 0b6d477 into IDR:master Feb 1, 2023

pwalczysko mentioned this pull request Feb 1, 2023

Value defaults to "-1" #24

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Search engine studies #20

Search engine studies #20

will-moore commented Oct 3, 2022 •

edited

Loading

jburel commented Nov 29, 2022

jburel commented Nov 29, 2022

will-moore commented Nov 29, 2022

jburel commented Dec 6, 2022

will-moore commented Dec 8, 2022 •

edited

Loading

jburel commented Jan 25, 2023 •

edited

Loading

jburel Jan 25, 2023

will-moore commented Jan 25, 2023

will-moore commented Jan 27, 2023

francesw commented Jan 27, 2023

will-moore commented Jan 30, 2023 •

edited

Loading

jburel commented Jan 30, 2023 •

edited

Loading

jburel commented Jan 30, 2023

will-moore commented Jan 30, 2023

will-moore commented Jan 31, 2023

pwalczysko commented Jan 31, 2023

pwalczysko commented Feb 1, 2023

will-moore commented Feb 1, 2023

pwalczysko commented Feb 1, 2023

Search engine studies #20

Search engine studies #20

Conversation

will-moore commented Oct 3, 2022 • edited Loading

jburel commented Nov 29, 2022

jburel commented Nov 29, 2022

will-moore commented Nov 29, 2022

jburel commented Dec 6, 2022

will-moore commented Dec 8, 2022 • edited Loading

jburel commented Jan 25, 2023 • edited Loading

jburel Jan 25, 2023

Choose a reason for hiding this comment

will-moore commented Jan 25, 2023

will-moore commented Jan 27, 2023

francesw commented Jan 27, 2023

will-moore commented Jan 30, 2023 • edited Loading

jburel commented Jan 30, 2023 • edited Loading

jburel commented Jan 30, 2023

will-moore commented Jan 30, 2023

will-moore commented Jan 31, 2023

pwalczysko commented Jan 31, 2023

pwalczysko commented Feb 1, 2023

will-moore commented Feb 1, 2023

pwalczysko commented Feb 1, 2023

will-moore commented Oct 3, 2022 •

edited

Loading

will-moore commented Dec 8, 2022 •

edited

Loading

jburel commented Jan 25, 2023 •

edited

Loading

will-moore commented Jan 30, 2023 •

edited

Loading

jburel commented Jan 30, 2023 •

edited

Loading