-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom 404 page #190
base: main
Are you sure you want to change the base?
Custom 404 page #190
Conversation
corpus/templates/404.html
Outdated
{% block content %} | ||
|
||
<style> | ||
@keyframes ieee404-wiggle { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of CSS here. Can you maybe move it to a separate file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be required. Just having the 404 file in the HTML should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too much custom CSS. Please try to use as much daisyUI, or Tailwind classes.
Description
This is a custom 404 page for corpus
Fixes #54
Dependencies
List any dependencies that are required for this change.
Type of Change
What types of changes does your code introduce?
Put an
x
in the boxes that applyHow Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.