Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom 404 page #190

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Custom 404 page #190

wants to merge 3 commits into from

Conversation

NikhilKottoli
Copy link
Contributor

@NikhilKottoli NikhilKottoli commented Dec 21, 2024

Description

This is a custom 404 page for corpus
Screenshot 2024-12-21 at 13 29 24
Screenshot 2024-12-20 at 00 14 14

Fixes #54

Dependencies

List any dependencies that are required for this change.

Type of Change

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an x in the boxes that apply

  • Pre-commit hook
  • Test B

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@NikhilKottoli NikhilKottoli marked this pull request as draft December 24, 2024 17:53
@NikhilKottoli NikhilKottoli marked this pull request as ready for review December 24, 2024 17:54
{% block content %}

<style>
@keyframes ieee404-wiggle {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of CSS here. Can you maybe move it to a separate file?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be required. Just having the 404 file in the HTML should work.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much custom CSS. Please try to use as much daisyUI, or Tailwind classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 Page
3 participants