Fix: ignore virtual attributes on serialization

ActsAsTaggable wrote a own pseudo column into the attributes hash
IFTTT · Oct 29, 2019 · ac88b32 · ac88b32
1 parent 7854221
commit ac88b32
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/polo/adapters/mysql.rb b/lib/polo/adapters/mysql.rb
@@ -4,7 +4,7 @@ class MySQL
  def on_duplicate_key_update(inserts, records)
  insert_and_record = inserts.zip(records)
  insert_and_record.map do |insert, record|
- attrs = record.is_a?(Hash) ? record.fetch(:values) : record.attributes
+ attrs = record.is_a?(Hash) ? record.fetch(:values) : record.attributes.slice(*record.class.column_names)
  values_syntax = attrs.keys.map do |key|
  "`#{key}` = VALUES(`#{key}`)"
  end
@@ -22,4 +22,4 @@ def ignore_transform(inserts, records)
  end
  end
  end
-end
+end
diff --git a/lib/polo/adapters/postgres.rb b/lib/polo/adapters/postgres.rb
@@ -19,7 +19,7 @@ def add_upsert_to_insert(insert, record)
  return naive_update_insert(insert, record)
  end
 
- attrs = record.is_a?(Hash) ? record.fetch(:values) : record.attributes
+ attrs = record.is_a?(Hash) ? record.fetch(:values) : record.attributes.slice(*record.class.column_names)
  values_syntax = attrs.keys.reject { |key| key.to_s == 'id' }.map do |key|
  %{"#{key}" = EXCLUDED."#{key}"}
  end
@@ -33,7 +33,7 @@ def add_upsert_to_insert(insert, record)
  def naive_update_insert(insert, record)
  table_name, id = table_name_and_key_for(record)
 
- attrs = record.is_a?(Hash) ? record.fetch(:values) : record.attributes_before_type_cast
+ attrs = record.is_a?(Hash) ? record.fetch(:values) : record.attributes_before_type_cast.slice(*record.class.column_names)
  updates = attrs.except('id').map do |key, value|
  column = ActiveRecord::Base.connection.send(:quote_column_name, key)