Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #222

Merged
merged 209 commits into from
Oct 23, 2024
Merged

Dev #222

merged 209 commits into from
Oct 23, 2024

Conversation

sergeiandreyev
Copy link
Contributor

Merge dev to main

stafverhaegen-chipflow and others added 30 commits May 27, 2024 14:34
* Remove labels on ESD diodes so they are now recognized as regular
  d(p)antenna diodes
* Increase width to minimum 0.48µm to account for new rule not yet in
  DRC check.

Signed-off-by: Staf Verhaegen <staf.verhaegen@chipflow.io>
OpenROAD, OpenROAD flow scripts, Qucs-S added as supported EDA tools.

Signed-off-by: Krzysztof Herman <141824113+KrzysztofHerman@users.noreply.github.com>
…nto dev

Merging synced dev  branch from own forc to local repo
-added partial implementation of class Pin from PyCell API
-added partial implementation of class Term from PyCell API
-added support for pins/terminals
-added support for XOR geometric transformation
-added support for text alignment/orientation
-fixed dbLayerXorList from geometry.py
-added support of npn13G2L and npn13G2V
-extended documentation

Signed-off-by: ThomasZecha <zecha@ihp-microelectronics.com>
Klayout PyCell integration
Signed-off-by: Daniel Arevalos <daniel.arevalos@sansano.usm.cl>
Signed-off-by: KrzysztofHerman <herman@ihp-microelectronics.com>
Signed-off-by: KrzysztofHerman <herman@ihp-microelectronics.com>
Signed-off-by: FaragElsayed2 <farag_agoor@mabrains.com>
Removing NO DRC filter for LVS runset for all layers
Remove NO_DRC filtering
…V mosfets

Signed-off-by: KrzysztofHerman <herman@ihp-microelectronics.com>
…m), symbols modified, some testcases modified

Signed-off-by: KrzysztofHerman <herman@ihp-microelectronics.com>
-added PyCell parameter type bool
-added partial implementation for PyCell API class Net
-added partial implementation for PyCell API class Path
-added partial implementation for PyCell API class ShapeFilter
-added support for Net's
-added generic registering of IHP PyCell's in Klayout
-added support for inductor2, inductor2_sc, inductor2_sp, inductor3,
 inductor3_sc and inductor3_sp
-updated documentation

Signed-off-by: ThomasZecha <zecha@ihp-microelectronics.com>
-fixed merge-error

Signed-off-by: ThomasZecha <zecha@ihp-microelectronics.com>
Klayout PyCell integration
Signed-off-by: Daniel Arevalos <daniel.arevalos@sansano.usm.cl>
…sistent w/ internal implementation

Signed-off-by: Sergei Andreev <andreev@ihp-microelectronics.com>
dnltz and others added 15 commits September 30, 2024 14:13
The input and output definition in the Verilog specify block
were positioned in the wrong order (output to input). Change
and also implement the tri-state better.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
Signed-off-by: Sergei Andreev <andreev@ihp-microelectronics.com>
iho-sg13g2: libs.ref: sg13g2_io: verilog: Fix specify syntax
…#37)

Signed-off-by: Sergei Andreev <andreev@ihp-microelectronics.com>
Signed-off-by: Sergei Andreev <andreev@ihp-microelectronics.com>
- removed explicit env items, user should put his own related settings

Signed-off-by: Sergei Andreev <116548619+sergeiandreyev@users.noreply.github.com>
Signed-off-by: KrzysztofHerman <herman@ihp-microelectronics.com>
Signed-off-by: KrzysztofHerman <herman@ihp-microelectronics.com>
Signed-off-by: Sergei Andreev <andreev@ihp-microelectronics.com>
Signed-off-by: KrzysztofHerman <herman@ihp-microelectronics.com>
added 1e14418 commit

Signed-off-by: Sergei Andreev <116548619+sergeiandreyev@users.noreply.github.com>
Signed-off-by: Sergei Andreev <andreev@ihp-microelectronics.com>
Signed-off-by: Sergei Andreev <andreev@ihp-microelectronics.com>
@dnltz
Copy link
Contributor

dnltz commented Oct 18, 2024

@sergeiandreyev looks like the DCO plugin is not configured correctly and doesn't run on pull requests to dev. Missing SOBs should be caught earlier.

dnltz and others added 4 commits October 18, 2024 10:29
This function has a hard depdendency to 'psutil' but is only required
when IHP_PYCELL_LIB_PRINT_PROCESS_TREE is set. Move 'getProcessNames'
inside the if block to allow using this PDK without 'psutil' installed.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
ihp-sg13g2: libs.tech: klayout: python: Move getProcessNames()
Revert "ihp-sg13g2: libs.tech: klayout: python: Move getProcessNames()"
@sergeiandreyev
Copy link
Contributor Author

@dnltz , do you mean as example these 'Merge' PRs?
image
these do not have have DCO signed

@dnltz
Copy link
Contributor

dnltz commented Oct 21, 2024

@sergeiandreyev no, they are fine. I mean this action (https://github.com/IHP-GmbH/IHP-Open-PDK/pull/222/checks?check_run_id=31736802611) only gets triggered when merging to the default branch. It doesn't check pull requests to dev, which is used as intermediate branch.

For example, this commit has no signed-off-by: 00ee762

@dnltz
Copy link
Contributor

dnltz commented Oct 21, 2024

@sergeiandreyev everything fine! Just saw my pull request (#172) failed not with missing signed-off-by!

@sergeiandreyev
Copy link
Contributor Author

ok, good!
still I don't understand for now why the merge PRs have DCO violations (see my previous comment)

@sergeiandreyev
Copy link
Contributor Author

it seems to be limited only to the commits from Oct 18..

@dnltz
Copy link
Contributor

dnltz commented Oct 21, 2024

it seems to be limited only to the commits from Oct 18..

I think so too.

I would just follow the DCO instructions:

To add your Signed-off-by line to every commit in this branch:

- Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).
- In your local branch, run: git rebase HEAD~208 --signoff
- Force push your changes to overwrite the branch: git push --force-with-lease origin dev

…branch in sg13g2_full.lylvs

Signed-off-by: Sergei Andreev <andreev@ihp-microelectronics.com>
@KrzysztofHerman KrzysztofHerman merged commit 035037f into main Oct 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.