Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Cnt rules #256

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Add more Cnt rules #256

wants to merge 3 commits into from

Conversation

dnltz
Copy link
Contributor

@dnltz dnltz commented Nov 10, 2024

More Cnt rules and a test GDS file to trigger violations. The file only contains Cont violations but can be extended in the future!

layout is drawn after the layout rules with each rule violating the requirements.

image

@dnltz
Copy link
Contributor Author

dnltz commented Nov 10, 2024

@akrinke I figured out Cnt.g1 generates no violation. Can you take a look why it doesn't?

@dnltz dnltz marked this pull request as draft November 11, 2024 05:54
@dnltz
libs.tech: klayout: drc: Add Cnt.c, Cnt.g1, Cnt.g2
72e8410 
Add three new DRC rules for Cont.

Cnt.g1 currently doesn't work!

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
@dnltz
libs.tech: klayout: drc: Add Test GDS
02dc43e 
Add test GDS file with violations to verify DRCs are actually
working. This GDS file contains wrong Cont placements to trigger
Cnt. rules.

Additionally, add pytest tests to run klayout and verify the
result.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
@dnltz
Add Tox
b93ac74 
Add Tox as infrastructure to run various Python checks. For now,
add pytest to run all DRC verification tests.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
@KrzysztofHerman
Copy link
Contributor

@dnltz this Cnt.g1 rule is still not implemented in the DRC deck.
The full list of not implemented rules is here:
https://github.com/IHP-GmbH/IHP-Open-PDK/blob/main/ihp-sg13g2/libs.tech/klayout/tech/drc/MissingRules_maximal.md

@sergeiandreyev
Copy link
Contributor

Hi @dnltz, thank you for contribution!
Did you check the rules on the DRC QA cells we have in the repo?
ihp-sg13g2/libs.qa/drc/layers/gds/sg13g2_qacells.gds, all the Cont rules are covered there

@akrinke
Copy link
Contributor

akrinke commented Nov 12, 2024

We have implemented new DRC rules in PR #259, including Cnt.c, Cnt.g1 and Cnt.g2 that are part of this pull request. Maybe you could remove the rule implementations from this PR, but keep the test infrastructure?

@dnltz
Copy link
Contributor Author

dnltz commented Nov 13, 2024

@sergeiandreyev ah, perfect they already exists. Thanks for pointing them out.

@akrinke Yes I can do that :)

@sergeiandreyev
Copy link
Contributor

Hi @dnltz, so what do you think, can we close this PR? since the updates are provided by @akrinke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofHerman KrzysztofHerman Awaiting requested review from KrzysztofHerman KrzysztofHerman is a code owner

@sergeiandreyev sergeiandreyev Awaiting requested review from sergeiandreyev sergeiandreyev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnltz @KrzysztofHerman @sergeiandreyev @akrinke