Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cflib implement notify setpoint stop #308

Closed
knmcguire opened this issue Oct 18, 2023 · 3 comments · Fixed by #309
Closed

cflib implement notify setpoint stop #308

knmcguire opened this issue Oct 18, 2023 · 3 comments · Fixed by #309
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@knmcguire
Copy link
Collaborator

The notify setpoint stop didn't exist in the cflib before so it was not implemented in crazyswarm2 yet. However, we now have it available in the commander cfilb since the last release. Also this needs to be implemented to the vel_mux teleoperate example since that will no longer take off after on flight.

That latter is also kind of linked to this issue bitcraze/crazyflie-lib-python#419

@knmcguire knmcguire added bug Something isn't working enhancement New feature or request labels Oct 18, 2023
@knmcguire knmcguire changed the title implement notify setpoint stop cflib backend cflib implement notify setpoint stop Oct 18, 2023
@knmcguire
Copy link
Collaborator Author

we....might need to implement this for c++ part as well. With the latest release candidate the hello world and such doesn't work anymore with takeoff

@whoenig
Copy link

whoenig commented Oct 31, 2023

The cpp backend has notifySetpointStop, though?

@knmcguire
Copy link
Collaborator Author

yeah, this is probably not an accurate statement. There is probably something else going on, since the cpp backend doesn't take off at all with the latest master of crazyflie-firmware so I thought it might be related to this (but it probably is not)

@knmcguire knmcguire self-assigned this Nov 16, 2023
@knmcguire knmcguire linked a pull request Nov 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants