cflib Add notify setpoints stop #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flight is for some reason a bit unstable.. still investigating! Let's not merge this just yet |
|
Seemed to fly fine! let's merge |
whoenig
approved these changes
Nov 16, 2023
|
One thing I forgot: perhaps we have in the documentation an entry in the feature table for notifysetpointstop that needs updating, too? Edit: I guess not: https://imrclab.github.io/crazyswarm2/overview.html |
|
ah... i don't think it is necessary. it's not a very important functionality (although it is for operation :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the notify setpoint stop to crazyswarm2.
It should also fix some doc about the teleop_keyboard tutorial and the tutorial itself.
fixes #307 and #308
This need some flight testing though before merge.