Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for downloadUSDLogfile #361

Merged
merged 4 commits into from
Nov 21, 2023
Merged

add support for downloadUSDLogfile #361

merged 4 commits into from
Nov 21, 2023

Conversation

whoenig
Copy link

@whoenig whoenig commented Nov 16, 2023

See #348

@whoenig
Copy link
Author

whoenig commented Nov 16, 2023

Based on the previous implementation without crazyflie-link-cpp. Draft, because this has not been tested on physical hardware, yet.

Copy link

@danteppc danteppc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install dlusd

@whoenig
Copy link
Author

whoenig commented Nov 17, 2023

What do you mean @danteppc ?

@danteppc
Copy link

What do you mean @danteppc ?

Apologies, this was by mistake

@whoenig whoenig marked this pull request as ready for review November 17, 2023 13:26
@whoenig
Copy link
Author

whoenig commented Nov 17, 2023

Tested on hardware. As before, the transfer speed is very low (4082.26 B/s), but this can still be useful in some applications. Note that the slow speed might also be related to the particular firmware implementation.

@danteppc
Copy link

danteppc commented Nov 17, 2023

I did a few tests, it seems to be working:

read 31674 in 6.6077 s. (4793.5 B/s).
read 205771 in 53.2812 s. (3861.98 B/s).
read 283289 in 73.9767 s. (3829.43 B/s).

but sometimes it stops in the middle, and the drone resets in failure (red led blinks 7 times every 2s)

@whoenig
Copy link
Author

whoenig commented Nov 17, 2023

This sort of failure would be a firmware bug and should be reported to Bitcraze. Normally, one would be able to see an error message with some details, but that's currently not enabled in downloadUSDLogfile.

@knmcguire
Copy link
Collaborator

knmcguire commented Nov 18, 2023

Hi! If you test this on the latest development branch (master) of the stm firmware, make sure to also update the NRF chip as well to the latest master branchh commit. We noticed some crossplay issues with the latest master of the stm with older versions of the NRF. Or try it with the 2023.06 release for both stm and nrf.

@Khaledwahba1994 Khaledwahba1994 merged commit c49236f into main Nov 21, 2023
3 checks passed
@Khaledwahba1994 Khaledwahba1994 deleted the issue348 branch November 21, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants