Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server cflib upload and start trajectory #372

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Conversation

knmcguire
Copy link
Collaborator

Should fix #71.

In draft until flight tested

@knmcguire
Copy link
Collaborator Author

I should also do flake8 fix and a doc change after the flighttest too.

@knmcguire
Copy link
Collaborator Author

found and fixed a bug during flight test. It was because I forgot that duration.sec was integer :).

Doc updated and autopep8 format, so now ready for review!

@knmcguire knmcguire marked this pull request as ready for review November 21, 2023 12:57
Copy link

@whoenig whoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Btw: we currently don't have flake8 etc. enabled in this folder, mostly due to a ROS bug that doesn't allow me to disable the check for our external dependencies (which are subdirectories of the crazyflie folder).

@knmcguire
Copy link
Collaborator Author

Ah no worries. At least the code is prettier 😁 I'll merge

@knmcguire knmcguire merged commit a81d442 into main Nov 21, 2023
3 checks passed
@knmcguire knmcguire deleted the add-cflib-trajecftroy branch August 29, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement trajectory upload and start on the cflib backend
2 participants