Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature systemtests sim fixed timestamp #411

Merged
merged 66 commits into from
Feb 2, 2024

Conversation

julienthevenoz
Copy link

  • Created systemtests_sim.yaml workflow file which runs on every push to main
  • modified test_flights.py to accept the --sim CLI argument which runs sim backend
  • Added an "avg temporal offset" value in the PDF to indicate how much desired and real graphs are offset (I tried to find a good value but there is always some randomness)
  • Created the "figure8_ideal_traj,csv" which includes takeoff and landing to compare desired and real trajectory better. This file is currently in systemtests folder (is that bad placement ?)

Copy link

@whoenig whoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few small & quick requests.

crazyflie_sim/crazyflie_sim/visualization/rviz.py Outdated Show resolved Hide resolved
.github/workflows/systemtests_sim.yml Show resolved Hide resolved
systemtests/test_flights.py Outdated Show resolved Hide resolved
@whoenig whoenig self-requested a review February 2, 2024 15:17
@whoenig whoenig merged commit 4260ba1 into main Feb 2, 2024
4 checks passed
@whoenig whoenig deleted the feature-systemtests-sim-fixed-timestamp branch February 2, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants