Add positioning doc #511
Merged
Add positioning doc #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #231 |
whoenig
reviewed
May 30, 2024
whoenig
approved these changes
May 30, 2024
There was a problem hiding this comment.
I think this is good. What's missing (perhaps another PR from me?):
- We should add a launch argument for tracking/positioning. Only if motion_capture is selected, we should run the motion_capture node
- The "motion_capture" key in crazyflies.yaml needs to be replaced to be "motion_capture_rigid_body_tracking" (and accordingly in the launch file), and the documentation regarding this expanded (custom tracking vs. mocap vendor software tracking)
knmcguire
commented
May 31, 2024
|
I have just added the launch file mocap argument since I've been hit by this problem many times myself :), however perhaps you can add the motion_capture_rigid_body_tracking as you know the most. Let me know if you agree with my launch file addition and I'll merge |
|
Looking great - thanks:-) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is some explanation about mocap and other positioning systems. I've placed it in the usage.rst file for now
It is not as extensive as the crazyswarm1 doc: https://crazyswarm.readthedocs.io/en/latest/configuration.html but I think that the motion capture package also provides quite doc and explanation about it as well. Same goes with the positioning for onboard positioning (like the loco deck, flow deck etc) which can be referred to the bitcraze website.