Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teleop parameter for server launch file #550

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

knmcguire
Copy link
Collaborator

Add a teleop parameter that enables the joy node. In reality this is no longer used that often though, so that is why the default is off.

fixes #67

Copy link

@whoenig whoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer the default to be true. We mostly use it for the "emergency" button. This condition should also be added to the teleop node itself, not only to joy?

@knmcguire
Copy link
Collaborator Author

Ahh oke then let's keep it to True then as default.

And yes you are right, I've added the condition to teleop as well, forgot that part!

@knmcguire knmcguire requested a review from whoenig July 24, 2024 08:16
@knmcguire knmcguire merged commit 77f2f3d into main Aug 5, 2024
5 checks passed
@knmcguire knmcguire deleted the add-teleop-parameter branch August 5, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Motion capture and teleop nodes on or off through launch.py
2 participants