Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK Validation workflow #988

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

OAK Validation workflow #988

wants to merge 3 commits into from

Conversation

anitacaron
Copy link
Contributor

Fixes #610

@anitacaron
Copy link
Contributor Author

I used CL as tester in PR obophenotype/cell-ontology#2274

@anitacaron anitacaron self-assigned this Jan 29, 2024
matentzn
matentzn reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sooo exciting! EDIT obophenotype/cell-ontology#2274

I didnt see your comment! I now seeee it! Cool!

matentzn
matentzn requested changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add example yaml file
  • Make tested ontology file configurable (noy hardcoded to "simple")
  • Make it possible to switch between open and closed-world validation (this needs to be done in oak - you can make and issue there and assign it to Harshad)

@matentzn matentzn added this to the 1.6 milestone Feb 24, 2024
@anitacaron anitacaron marked this pull request as draft February 26, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@anitacaron anitacaron

Labels
None yet
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

Consider replacing some of the SPARQL QC checks with OAK validate
2 participants
@anitacaron @matentzn