Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T36 data format v2 #37

Open
wants to merge 67 commits into
base: main
Choose a base branch
from
Open

T36 data format v2 #37

wants to merge 67 commits into from

Conversation

jgroehl
Copy link
Member

@jgroehl jgroehl commented Jun 26, 2023

No description provided.

Scott Miller and others added 28 commits June 2, 2022 10:56
…-device-and-data

1 create converter for imagio pa device and data
…a-device-and-data

1 create converter for imagio pa device and data
…smiller-main

# Conflicts:
#	examples/python/visualise_zenodo_example_data.py
#	pacfish/core/Metadata.py
#	requirements.txt
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 37.50% and project coverage change: -8.55 ⚠️

Comparison is base (4dee0db) 89.46% compared to head (389f428) 80.92%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   89.46%   80.92%   -8.55%     
==========================================
  Files          19       20       +1     
  Lines         997     1195     +198     
==========================================
+ Hits          892      967      +75     
- Misses        105      228     +123     
Flag Coverage Δ
pytests 80.92% <37.50%> (-8.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pacfish/qualitycontrol/PADataIntegrityCheck.py 100.00% <ø> (ø)
pacfish/api/adapters/Imagio_File_Converter.py 27.67% <27.67%> (ø)
pacfish/qualitycontrol/ConsistencyChecker.py 91.86% <57.14%> (-3.55%) ⬇️
pacfish/iohandler/file_reader.py 87.23% <75.00%> (-6.32%) ⬇️
pacfish/api/BaseAdapter.py 92.10% <100.00%> (+0.21%) ⬆️
pacfish/api/adapters/Nrrd_File_Converter.py 100.00% <100.00%> (ø)
pacfish/api/adapters/__init__.py 100.00% <100.00%> (ø)
pacfish/core/Metadata.py 99.46% <100.00%> (+<0.01%) ⬆️
pacfish/iohandler/file_writer.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jgroehl
Copy link
Member Author

jgroehl commented Jun 22, 2024

@amasmiller is there any chance to still test if the proposed changes to the data format will work for you?
It is a minor change that re-defined the definition of "frame", where a list of wavelengths is now kept separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants