Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for implemented features and related implementations #15

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

abujeda
Copy link
Collaborator

@abujeda abujeda commented Jul 1, 2024

I have completed all the changes required for the features available in the Smartsheet spreadsheet.

I left out the features that are not implemented and other issues like documentation.

@abujeda abujeda requested a review from jp-tosca July 1, 2024 17:30
@jp-tosca
Copy link
Collaborator

jp-tosca commented Jul 9, 2024

Thanks a lot @abujeda, this looks very nice! I see that this PR has some changes besides the documentation. Do you need me to do anything with the other changes? If not, should I approve or merge this?

@abujeda
Copy link
Collaborator Author

abujeda commented Jul 9, 2024

I see what you mean. There is one refactoring that is not part of the documentation. I will remove this from this PR.

@abujeda abujeda force-pushed the feature_descriptions_01 branch from 5979a05 to dae0ec7 Compare July 9, 2024 16:49
@abujeda
Copy link
Collaborator Author

abujeda commented Jul 9, 2024

I have removed the code changes. Now there is only documentation.

Please approve and merge

@jp-tosca jp-tosca merged commit 48f3b50 into main Jul 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants