Improve plots

ISI-MIP · Nov 30, 2023 · a5f083b · a5f083b
1 parent 9be1af1
commit a5f083b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/isimip_qa/plots/dayofyear.py b/isimip_qa/plots/dayofyear.py
@@ -14,9 +14,9 @@ class DayOfYearPlot(FigurePlotMixin, GridPlotMixin, Plot):
 
     def get_df(self, dataset):
         extraction = self.extraction_class(dataset, self.region, self.period)
-        df = extraction.read()
+        df = extraction.read().groupby(lambda x: x.dayofyear).mean()
         mean, std =  df.mean().values, df.std().values
-        return (df.groupby(lambda x: x.dayofyear).mean() - mean) / (std if std > 0 else 1.0)
+        return (df - mean) / (std if std > 0 else 1.0)
 
     def get_attrs(self, dataset):
         return AttrsExtraction(dataset, self.region, self.period).read()

diff --git a/isimip_qa/plots/monthofyear.py b/isimip_qa/plots/monthofyear.py
@@ -14,9 +14,9 @@ class MonthOfYearPlot(FigurePlotMixin, GridPlotMixin, Plot):
 
     def get_df(self, dataset):
         extraction = self.extraction_class(dataset, self.region, self.period)
-        df = extraction.read()
+        df = extraction.read().groupby(lambda x: x.month).mean()
         mean, std =  df.mean().values, df.std().values
-        return (df.groupby(lambda x: x.month).mean() - mean) / (std if std > 0 else 1.0)
+        return (df - mean) / (std if std > 0 else 1.0)
 
     def get_attrs(self, dataset):
         return AttrsExtraction(dataset, self.region, self.period).read()