move inchi-1 specific functions out of library #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note, the CI action fails (at least in my fork) due to some recent changes in the build/test scripts that fails due to the |
|
The added commit fixes the tests by using SHA instead of branch name to set the library filename |
giallu
force-pushed
the
giallu/move_inchi-1_specific_functions
branch
from
b00a827 to
0cf5cca
Compare
|
Sorry, had to force/push to remove an unrelated change that sneaked into the SHA commit |
giallu
force-pushed
the
giallu/move_inchi-1_specific_functions
branch
2 times, most recently
from
619c09b to
3031bf4
Compare
giallu
force-pushed
the
giallu/move_inchi-1_specific_functions
branch
from
3031bf4 to
934405f
Compare
JanCBrammer
force-pushed
the
rwth
branch
5 times, most recently
from
1d99ad3 to
cfee545
Compare
JanCBrammer
force-pushed
the
rwth
branch
3 times, most recently
from
3d933ef to
fcd8c4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrintFileName and SplitTime are compiled in the library only when TARGET_API_LIB is not defined, but that is never the case in the cmake build so it fails.
Apparently, those two symbols and few others like DetectInputINChIFileType are only used in the inchi-1 executable, so they were moved in ichimain.c
Please note, this raises a few questions about the whole build system (please let me know if it's better to discuss this elsewhere). In particular, it seems the original Makefiles sort of build a slightly different library depending on the target being built; this makes things a bit confusing in the code and hard to grasp due to the various combinations possible.
Also, this is completely unsupported with cmake so I hope you are open to patches like the present one in order to gradually move toward removing them.
For the record, after this patch is applied there are 32 instances left of
#ifndef TARGET_API_LIBthat I need to investigate because that's code never built into the library, and 17 instances of the reverse check#ifdef TARGET_API_LIBthat mostly seem to add some symbols to the library.