Fix: New created users will have unusable password #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
commented
Feb 15, 2024
Comment on lines
+465
to
+467
| # Since a new user object is created, the password | ||
| # field is set to have an unusable password. | ||
| self.assertEqual(user.has_usable_password(), False) |
There was a problem hiding this comment.
@peppelinux I piggy backed on an existing test case to verify that new user will have an unusable password. No change would be made for user objects where password is already set.
pandafy
force-pushed
the
set-unusable-password-on-create
branch
from
1d1508b
to
7699475
Compare
pandafy
changed the title
peppelinux
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #398