Added a class that implements read only of a file. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file is expected to contain a set of information pieces. One per line. The class acts like a list, except that it's non-mutable..
peppelinux
approved these changes
Feb 10, 2024
tests/test_14_read_only_list_file.py
Outdated
Comment on lines
21
to
23
| for item in ["one", "two", "three"]: | ||
| fp.write(item) | ||
| fp.write("\n") |
There was a problem hiding this comment.
Suggested change
| for item in ["one", "two", "three"]: | |
| fp.write(item) | |
| fp.write("\n") | |
| fb.writelines(["one", "two", "three"]) |
There was a problem hiding this comment.
The '\n' at the end of the line is significant and writelines doesn't add those so I adopted a variant of what you proposed.
src/idpyoidc/storage/listfile.py
Outdated
Comment on lines
84
to
87
| if info == "": | ||
| return None | ||
| else: | ||
| return info |
There was a problem hiding this comment.
Suggested change
| if info == "": | |
| return None | |
| else: | |
| return info | |
| return info or None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file is expected to contain a set of information pieces. One per line. The class acts like a list, except that it's non-mutable..