Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitelist check #27

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Add whitelist check #27

merged 4 commits into from
Aug 23, 2024

Conversation

egrace479
Copy link
Member

Adds whitelist check on requirements file to ingestion program. Also adds the preliminary whitelist proposed here; this will be updated to match the final decision with A3D3 and iHarp.

@egrace479 egrace479 added the enhancement New feature or request label Aug 19, 2024
@egrace479 egrace479 added this to the Challenge Released milestone Aug 19, 2024
@egrace479 egrace479 requested a review from work4cs August 19, 2024 16:31
ingestion_program/ingestion.py Outdated Show resolved Hide resolved
ingestion_program/ingestion.py Outdated Show resolved Hide resolved
@work4cs
Copy link
Collaborator

work4cs commented Aug 20, 2024

May I ask what the most convenient way for us to continuously add packages to whitelist.txt shared among organizations? For example, if I want to add a package right now, what should I do? Thank you!

@egrace479
Copy link
Member Author

egrace479 commented Aug 20, 2024

May I ask what the most convenient way for us to continuously add packages to whitelist.txt shared among organizations? For example, if I want to add a package right now, what should I do? Thank you!

@work4cs, please see the A3D3 PR for the whitelist. If you have a specific suggestion, feel free to add it there (you can also add it here now).

egrace479 and others added 2 commits August 21, 2024 17:38
use pypi's full versioning regex

Co-authored-by: Jiaman Wu <47147576+work4cs@users.noreply.github.com>
Add more packages suggested in a3d3-institute/HDRchallenge#5

Co-authored-by: Jiaman Wu <47147576+work4cs@users.noreply.github.com>
@egrace479 egrace479 requested a review from work4cs August 21, 2024 21:41
@work4cs work4cs merged commit 2e54051 into set-up Aug 23, 2024
@work4cs work4cs deleted the feature/whitelist branch August 23, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants