Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --cls-file to predict command #37

Merged
merged 7 commits into from
Aug 23, 2024
Merged

Add --cls-file to predict command #37

merged 7 commits into from
Aug 23, 2024

Conversation

johnbradley
Copy link
Collaborator

Fixes #30

@johnbradley johnbradley requested review from hlapp and egrace479 August 22, 2024 14:58
@hlapp
Copy link
Member

hlapp commented Aug 22, 2024

Looks good. What I was originally thinking is to allow the argument to --cls to be file name (it's already a string), and if it's indeed an existing file path, it will simply read that file, and if it's not, it will treat it as a string of class names. Obviously, this would prevent detection of a mis-spelled file name or path.

Not sure what's common and/or recommended practice. I can see how having two different arguments is cleaner. Thoughts either way @johnbradley?

@johnbradley
Copy link
Collaborator Author

That sounds good to me @hlapp.

egrace479
egrace479 reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@egrace479 egrace479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One missed change from @hlapp's suggestion and one suggestion for clearer help message. Looks good!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/bioclip/__main__.py Outdated Show resolved Hide resolved
johnbradley
johnbradley commented Aug 22, 2024
View reviewed changes
src/bioclip/__main__.py Outdated Show resolved Hide resolved
johnbradley and others added 4 commits August 22, 2024 12:42
@johnbradley @egrace479
Apply suggestions from code review
124f534 
Co-authored-by: Elizabeth Campolongo <38985481+egrace479@users.noreply.github.com>
@johnbradley @egrace479
Update README.md
e791a4b 
Co-authored-by: Elizabeth Campolongo <38985481+egrace479@users.noreply.github.com>
@johnbradley @egrace479
Update src/bioclip/__main__.py
147eb57 
Co-authored-by: Elizabeth Campolongo <38985481+egrace479@users.noreply.github.com>
@johnbradley
Fix empty cls
5317df1
@johnbradley johnbradley requested review from hlapp and egrace479 and removed request for hlapp August 22, 2024 18:47
hlapp
hlapp approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

egrace479
egrace479 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@egrace479 egrace479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@johnbradley johnbradley merged commit 3f65a47 into main Aug 23, 2024
1 check passed
@johnbradley johnbradley deleted the 30-classes-file branch August 23, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlapp hlapp hlapp approved these changes

@egrace479 egrace479 egrace479 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow providing custom classes as a file
3 participants
@johnbradley @hlapp @egrace479