Add apptainer support #41
Merged
+46
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apptainer copies the labels from the upstream image so no extra labeling config was needed. |
hlapp
approved these changes
Sep 4, 2024
apptainer.def
Outdated
| PYBIOCLIP_VERSION= | ||
|
|
||
| %runscript | ||
| exec bash |
There was a problem hiding this comment.
I'm using exec "$@" elsewhere, but that's for a container that has a defined entry point defined in the Dockerfile (a Jupyter container). Not sure how to assess whether that would be better or not.
There was a problem hiding this comment.
I tried this out and it does work better. I'm going to make this change.
Adds apptainer definition and config to automatically build the apptainer image on release. The apptainer image is based on the docker image. Part of #27 Co-authored-by: Hilmar Lapp <hlapp@drycafe.net>
johnbradley
force-pushed
the
apptainer
branch
from
04f5155 to
1909a17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds apptainer definition and config to automatically build the apptainer image on release. The apptainer image is based on the docker image.
Part of #27