-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac setup #135
Mac setup #135
Conversation
Code size report:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand much without trying it out. So I will approve and trust your experiments on MAC for the working :)
- I tried from cmd prompt the script and can confirm it does not break anything existing.
- Feedback:
Here I would prefer to see the version number rather than "latest". Or maybe both "version number (latest)" is fine. - By the way, the following print statements is in intended order? :
I think "Firmware hello-world deployed successfully" followed by "Firmware mpy-psoc6 deployed successfully" is bit confusing. Maybe @ederjc is a better test object here to comment.
99ecc36
to
4fcc751
Compare
I would also prefer the version number rather than the latest |
78c2645
to
21fdcfc
Compare
21fdcfc
to
a9a85a5
Compare
I tested it - looks good for me 👍 |
a9a85a5
to
9fdc7af
Compare
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
@ederjc I need to the check the argparse lib options for default subparsers. An alternative would be that the script finds out if it has been called by the command line or by clicking. And that seems more or less trivial for one OS but hard to maintain cross platform. The clickable option was dropped with the OS dedicated scripts removal. We can add a ticket for this click default option. I think there should be an easy (to maintain) way. But I will close now this one. |
@jaenrig-ifx Yes, this "double clicking" thought is not urgent and should not block this merge. |
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Changes:
Reviewers please:
https://ifx-micropython.readthedocs.io/en/mac-setup/psoc6/intro.html -->
https://ifx-micropython.readthedocs.io/en/mac-setup/psoc6/installation.html