Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac setup #135

Merged
merged 24 commits into from
Jun 10, 2024
Merged

Mac setup #135

merged 24 commits into from
Jun 10, 2024

Conversation

jaenrig-ifx
Copy link
Member

@jaenrig-ifx jaenrig-ifx commented May 31, 2024

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Changes:

  • Modified "mpy-psoc6.py" script for macOS support
  • Minor improvements in "mpy-psoc6.py" script user experience (notified waiting restart)
  • "mpy-psoc6.py" script uses now openocd v5
  • Removed "quick-start" command from "mpy-psoc6.py"
  • Removed OS specific scripts for Win and Linux
  • Updates in installation and getting started psoc6 docs with mentioned changes.

Reviewers please:

Copy link

github-actions bot commented May 31, 2024

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:   +48 +0.012% PYBV10
     mimxrt:   +52 +0.014% TEENSY40
        rp2:   +56 +0.006% RPI_PICO_W
       samd:   +48 +0.018% ADAFRUIT_ITSYBITSY_M4_EXPRESS

Copy link
Member

@NikhitaR-IFX NikhitaR-IFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand much without trying it out. So I will approve and trust your experiments on MAC for the working :)

  • I tried from cmd prompt the script and can confirm it does not break anything existing.
  • Feedback:
    image
    Here I would prefer to see the version number rather than "latest". Or maybe both "version number (latest)" is fine.
  • By the way, the following print statements is in intended order? :
    image

I think "Firmware hello-world deployed successfully" followed by "Firmware mpy-psoc6 deployed successfully" is bit confusing. Maybe @ederjc is a better test object here to comment.

@IFX-Anusha
Copy link

I don't understand much without trying it out. So I will approve and trust your experiments on MAC for the working :)

  • I tried from cmd prompt the script and can confirm it does not break anything existing.
  • Feedback:
    image
    Here I would prefer to see the version number rather than "latest". Or maybe both "version number (latest)" is fine.
  • By the way, the following print statements is in intended order? :
    image

I think "Firmware hello-world deployed successfully" followed by "Firmware mpy-psoc6 deployed successfully" is bit confusing. Maybe @ederjc is a better test object here to comment.

I would also prefer the version number rather than the latest

@jaenrig-ifx
Copy link
Member Author

jaenrig-ifx commented Jun 4, 2024

hello world flashing is now hidden 😺

image

@ederjc
Copy link
Member

ederjc commented Jun 7, 2024

I tested it - looks good for me 👍
Can we make device-setup the default option when called without parameters? Then this could be started by double-clicking also

Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
@jaenrig-ifx
Copy link
Member Author

@ederjc I need to the check the argparse lib options for default subparsers.

An alternative would be that the script finds out if it has been called by the command line or by clicking. And that seems more or less trivial for one OS but hard to maintain cross platform.

The clickable option was dropped with the OS dedicated scripts removal. We can add a ticket for this click default option. I think there should be an easy (to maintain) way. But I will close now this one.

@ederjc
Copy link
Member

ederjc commented Jun 10, 2024

@jaenrig-ifx Yes, this "double clicking" thought is not urgent and should not block this merge.
It can be considered during the next change of the script.

@jaenrig-ifx jaenrig-ifx merged commit 12d761c into ports-psoc6-main Jun 10, 2024
29 checks passed
@jaenrig-ifx jaenrig-ifx deleted the mac-setup branch June 11, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants