Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/imagimob: Adding imagimob mp integration. #179

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

NikhitaR-IFX
Copy link
Member

Summary

Integration for imagimob and micropython.

Knowing this is the first version, it does the job fine for now. I have only tested to check if imports are working fine. Praveen is going to eventually use/extend this for the application he is working on.

I suggest we don't merge this to ports-psoc6-main and rather keep the changes alive in imai-mp-integration branch for now.
In case we see the need to extend this, then:

  1. We should explore how to add right architecture and then cross compile for our port.
  2. Provide script that can be run from imagimob studio so that the workflow is fully automated.
  3. Provide necessary docs.

For reviewing, you can ignore the non-mpy files.

Testing

Details available in readme.md.

Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Copy link
Member

@jaenrig-ifx jaenrig-ifx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, beside the small comment! 🦾

Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Copy link

@ramya-subramanyam ramya-subramanyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@@ -220,6 +220,7 @@ extern void machine_deinit();

#define MICROPY_LOGGER_DEBUG (0)


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this file be reverted as there are no changes here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@NikhitaR-IFX NikhitaR-IFX removed the request for review from ederjc August 23, 2024 04:45
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Copy link

@IFX-Anusha IFX-Anusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@NikhitaR-IFX NikhitaR-IFX merged commit 1562205 into imai-mp-integration Aug 23, 2024
20 checks passed
@NikhitaR-IFX NikhitaR-IFX deleted the en-imai branch August 23, 2024 05:25
@NikhitaR-IFX NikhitaR-IFX mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants