-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples/imagimob: Adding imagimob mp integration. #179
Conversation
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, beside the small comment! 🦾
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
ports/psoc6/mpconfigport.h
Outdated
@@ -220,6 +220,7 @@ extern void machine_deinit(); | |||
|
|||
#define MICROPY_LOGGER_DEBUG (0) | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this file be reverted as there are no changes here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: NikhitaR-IFX <Nikhita.Rajasekhar@infineon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Summary
Integration for imagimob and micropython.
Knowing this is the first version, it does the job fine for now. I have only tested to check if imports are working fine. Praveen is going to eventually use/extend this for the application he is working on.
I suggest we don't merge this to ports-psoc6-main and rather keep the changes alive in imai-mp-integration branch for now.
In case we see the need to extend this, then:
For reviewing, you can ignore the non-mpy files.
Testing
Details available in readme.md.