ports/psoc6/modules/machine/machine_adc: WIP refactor relationship. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
| uint8_t id; | ||
| uint8_t bits; | ||
| // machine_adc_obj_t *channel[ADC_BLOCK_CHANNEL_MAX]; | ||
| machine_adc_obj_t *channel[ADC_BLOCK_CHANNEL_MAX]; |
There was a problem hiding this comment.
I still miss to see what is this holding or where is the assignment happening
There was a problem hiding this comment.
Rest refactoring looks good to me. While testing it out, I realized still 2nd time instantiation of the same pin for ADC does not return any error or message "pin associated to block already created" - which we could ofcourse include, but the read functions don't work anymore then. I have attached here a screenshot.
But I think this could also be a warning/note to user in docs since I don't know if this happens for other ports and if it his is addressed?
NikhitaR-IFX
approved these changes
Jul 27, 2023
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
NikhitaR-IFX
approved these changes
Jul 31, 2023
|
I will merge this now as this is working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---