-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Machine clean & docs update #99
Conversation
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
@@ -411,8 +412,17 @@ MISO P9_1 P6_1 P10_1 | |||
SCK P9_2 P6_2 P10_2 | |||
===== =========== ============ ============ | |||
|
|||
.. | |||
|
|||
TODO: This is only applicable to the CY8CPROTO-062-4343W. This does not belong here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is specific to only proto board. But also, in mpy official docs other ports which support multiple boards still have I guess the most common board reference (pinouts etc.) in quickref. But we will have to move around our docs a bit. Maybe have common port docs and point out to getting started with different boards or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, other ports show only one board. We have to discuss this in the strategy, and find our compromise for maintainability - user friendliness.
docs/psoc6/quickref.rst
Outdated
@@ -425,7 +435,7 @@ SPI object is created with default settings or settings of previous initializati | |||
:: | |||
|
|||
from machine import SPI | |||
spi = SPI(0) # Default assignment: id=0, sck=P9_2 ,MOSI=P9_0, MISO=P9_1, baudrate=1000000, Polarity=0, Phase=0, bits=8, firstbit=SPI.MSB | |||
spi = SPI(0, sck='P11_2', mosi='P11_0', miso='P11_1') # Default assignment: id=0, sck=P9_2 ,MOSI=P9_0, MISO=P9_1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here pins and comment is mismatched. I think it should be
spi = SPI(0, sck='P9_2', mosi='P9_0', miso='P9_1') # Default assignment: id=0, baudrate=1000000, Polarity=0, Phase=0, bits=8, firstbit=SPI.MSB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. Let me fix it!
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
2898339
to
567a339
Compare
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
To review after #98.